[YouTube] Realign n-sig
processing with yt-dlp
#32695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR revises the processing of the
n-sig
YT parameter in theYoutubeIE
extractor to realign the code with that in yt-dlp.Some additional methods from the yt-dlp
InfoExtractor
class have already been back-ported in yt-dlp; this PR adds further such methods needed by the unified code.Finally, some obvious test failures are fixed, including a new extraction tactic for
like_count
fromlikeButtonViewModel
in the YT page, as recently implemented in yt-dlp (thanks @Ganesh910, yt-dlp/yt-dlp#8763).